Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSC3440: Threading via
m.thread
relation #3440MSC3440: Threading via
m.thread
relation #3440Changes from 16 commits
beda89e
2fa27ac
d8a0a94
7d39887
6e37911
c142b17
c578f75
33acdf4
7102165
f84f949
f02dc8d
3e46728
44e967f
65d0d55
2b76a6e
99c5b2e
4ee42b1
fc81bbd
91e6ec7
eaeef00
26fb5f2
a23c795
6b1a368
f227592
b493f21
46e1e9b
e40efa0
23928e7
0880a86
1bbb021
3c977f7
0140454
700464c
0035202
e3cb699
847f468
c8ffa62
a7cbf8d
5896d69
ee5df80
00daf64
a5d8aab
d7ed3c4
5c04906
d667a0b
b157dfd
3162bea
fa232f4
68d9c42
5bbb015
707af2b
b28a365
8f82dfa
8f8be64
b6d8076
cd671ef
a61c01e
362e661
b831fb3
e2dde8e
e640f6b
bda3a1e
89c4b5e
61bb518
9159a5a
a97307a
f541dab
82b4c62
75f4cb2
54ce185
6d6baa2
893cf1f
641e326
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an uncovered case: replying to a message in a thread from outside a thread, i.e.
m.in_reply_to
exists, butm.thread
does not. This happens particularly when replying from a client that isn't yet thread-aware, e.g. currently conversations between element web with labs threads and element android. I come here from element-hq/element-web#19910 to discuss this very case, because - in my understanding - currently element web handles it contrary to the way of what @gsouquet suggests in his earlier comment which is now marked as resolved even though the MSC hasn't been amended to cover it:Replying to a threaded message from a currently unaware client like element android will on element web show the reply in the thread as if it had the
m.thread
relation. Repeating this (reply to reply to threaded message, etc.) currently breaks and the 2nd level of reply is shown on the main timeline again.Allowing replies to threaded events without being part of the thread may be regarded as either:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for bringing this up!
I reviewed the behaviour an I agree with the conclusion that you came to. An event that has
m.in_reply_to
but norel_type:m.thread
should be display in the room, and Element should not try to be smart and display that message in a thread.This will only be done if clients that do not fully support thread decide to attach the new relation. This will open the door to have a reply in the main timeline targetting a threaded event in case one wants to advertise a piece of the conversation to a wider audience.