Skip to content

MSC2746: Improved VoIP Signalling #2746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 81 commits into from
Apr 28, 2023
Merged

MSC2746: Improved VoIP Signalling #2746

merged 81 commits into from
Apr 28, 2023

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Aug 21, 2020 •
edited by turt2live
Loading

A proposal introducing a number of mechanisms to 1:1 VoIP calls, adding:

  • Better reliability, especially in the presence of multiple devices
  • Renegotiation (ICE restarts, hold/resume, voice/video upgrade)
  • DTMF

Implementation: https://github.com/matrix-org/matrix-js-sdk/tree/develop/src/webrtc

Rendered

FCP tickyboxes

@dbkr dbkr added voip proposal A matrix spec change proposal labels Aug 21, 2020
@turt2live turt2live added the kind:feature MSC for not-core and not-maintenance stuff label Aug 21, 2020
@dbkr dbkr marked this pull request as ready for review August 21, 2020 18:20
@turt2live turt2live changed the title Improved VoIP Signalling MSC2746: Improved VoIP Signalling Aug 21, 2020
@turt2live turt2live self-requested a review August 21, 2020 18:22
@dbkr
Copy link
Member Author

dbkr commented Aug 21, 2020

There's no implementation of this yet: seeking early feedback in advance of starting an impl.

dbkr and others added 5 commits August 24, 2020 09:50
@dbkr @ara4n
Typo
37c1f98 
Co-authored-by: Matthew Hodgson <[email protected]>
@dbkr @ara4n
Typo
5156caf 
Co-authored-by: Matthew Hodgson <[email protected]>
@dbkr
Switch to m.call.select_answer
fe8b1eb
@dbkr
Make self-calling possible
6c4a077 
Replaces `answer_id` with `party_id` and introduces the `invitee`
field on `m.call.invite`.
@dbkr
Nobody spotted the deliberate typo
25ed29a
babolivier
babolivier reviewed Sep 3, 2020
View reviewed changes
richvdh
richvdh reviewed Sep 11, 2020
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all seems generally sane to me.

anoadragon453
anoadragon453 approved these changes Apr 23, 2023
View reviewed changes
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only have wording corrections. The rest of the logic looks sound!

proposals/2746-reliable-voip.md Outdated
Comment on lines 19 to 23
The version property is changed to `"1"` in all existing VoIP events
([`m.call.answer`](https://spec.matrix.org/v1.5/client-server-api/#mcallanswer),
[`m.call.candidates`](https://spec.matrix.org/v1.5/client-server-api/#mcallcandidates),
[`m.call.hangup`](https://spec.matrix.org/v1.5/client-server-api/#mcallhangup)
[`m.call.invite`](https://spec.matrix.org/v1.5/client-server-api/#mcallinvite)).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you call out more explicitly that you're changing the type of the version field across all of these event types from a number/integer to a string? (Or just link to the Unstable Prefix section of this MSC, having now read it.)

@mscbot
Copy link
Collaborator

mscbot commented Apr 23, 2023

🔔 This is now entering its final comment period, as per the review above. 🔔

@mscbot mscbot added final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels Apr 23, 2023
@mscbot
Copy link
Collaborator

mscbot commented Apr 28, 2023

The final comment period, with a disposition to merge, as per the review above, is now complete.

@mscbot mscbot added finished-final-comment-period and removed disposition-merge final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels Apr 28, 2023
@anoadragon453 anoadragon453 merged commit 88296a7 into old_master Apr 28, 2023
@anoadragon453 anoadragon453 deleted the dbkr/msc2746 branch April 28, 2023 09:06
@anoadragon453 anoadragon453 restored the dbkr/msc2746 branch April 28, 2023 09:07
@anoadragon453 anoadragon453 added spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec and removed finished-final-comment-period labels Apr 28, 2023
anoadragon453 pushed a commit that referenced this pull request Apr 28, 2023
@dbkr @anoadragon453
MSC2746: Improved VoIP Signalling (#2746)
ea715b7
@dbkr dbkr mentioned this pull request May 4, 2023
Merged
@turt2live
Copy link
Member

Spec PR: matrix-org/matrix-spec#1511

@turt2live turt2live added spec-pr-in-review A proposal which has been PR'd against the spec and is in review release-blocker and removed spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec release-blocker labels May 16, 2023
@turt2live
Copy link
Member

Merged 🎉

@turt2live turt2live added merged A proposal whose PR has merged into the spec! and removed spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels May 23, 2023
@clokep clokep mentioned this pull request May 24, 2023
Closed
12 tasks
This was referenced May 24, 2023
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwindels bwindels bwindels left review comments

@turt2live turt2live turt2live left review comments

@ara4n ara4n ara4n left review comments

@anoadragon453 anoadragon453 anoadragon453 approved these changes

@richvdh richvdh richvdh approved these changes

@babolivier babolivier babolivier left review comments

@deepbluev7 deepbluev7 deepbluev7 left review comments

@SimonBrandner SimonBrandner SimonBrandner left review comments

@zecakeh zecakeh zecakeh left review comments

@uhoreg uhoreg uhoreg approved these changes

@Bishhhh1717 Bishhhh1717 Bishhhh1717 approved these changes

Assignees
No one assigned
Labels
kind:feature MSC for not-core and not-maintenance stuff merged A proposal whose PR has merged into the spec! proposal A matrix spec change proposal voip
Projects
Spec Core Team Backlog
Status: Done to some definition
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.