Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSC2702: Specifying semantics for Content-Disposition on media #2702

Merged
merged 12 commits into from
Jan 29, 2024
Merged

MSC2702: Specifying semantics for Content-Disposition on media #2702

merged 12 commits into from
Jan 29, 2024

Conversation

turt2live
Copy link
Member

@turt2live turt2live commented Jul 28, 2020 •
edited by tulir
Loading

@turt2live turt2live added proposal-in-review proposal A matrix spec change proposal kind:maintenance MSC which clarifies/updates existing spec labels Jul 28, 2020
@turt2live turt2live mentioned this pull request Jul 28, 2020
Closed
@KB1RD KB1RD mentioned this pull request Jul 28, 2020
Draft
@turt2live
Copy link
Member Author

Implementation: t2bot/matrix-media-repo@da0be74

@turt2live turt2live added needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. and removed needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. labels Jun 8, 2021
davidegirardi
davidegirardi reviewed Sep 7, 2023
View reviewed changes
Copy link

@davidegirardi davidegirardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This review contains 3 comments but 2 of them are old ones. I will try to remove them after submitting this.

proposals/2702-media-content-disposition.md Outdated Show resolved Hide resolved
proposals/2702-media-content-disposition.md Outdated Show resolved Hide resolved
proposals/2702-media-content-disposition.md Outdated Show resolved Hide resolved
@turt2live
Copy link
Member Author

I think this is ready to go as a "nice to have" item for Matrix 1.9/the future:

@mscbot fcp merge

@mscbot
Copy link
Collaborator

mscbot commented Sep 8, 2023 •
edited by dbkr
Loading

Team member @mscbot has proposed to merge this. The next step is review by the rest of the tagged people:

Concerns:

  • outstanding discussion threads

Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for information about what commands tagged team members can give me.

@mscbot mscbot added proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. disposition-merge labels Sep 8, 2023
uhoreg
uhoreg reviewed Jan 9, 2024
View reviewed changes
proposals/2702-media-content-disposition.md
* `audio/x-wav`
* `audio/x-pn-wav`
* `audio/flac`
* `audio/x-flac`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the sake of anyone (like me) who's surprised that audio/opus isn't on the list, the audio/opus mimetype seems to be specifically for RTP payloads. Recorded files (such as what we would use in voice messages) would be served with the audio/ogg mimetype.

Copy link
Member

@dbkr dbkr Jan 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, flac has its own container format for some reason. Opus just lives in ogg/webm/mp4 (it's the hermit crab of codecs).

@richvdh richvdh removed their request for review January 10, 2024 16:58
@mscbot
Copy link
Collaborator

mscbot commented Jan 23, 2024

🔔 This is now entering its final comment period, as per the review above. 🔔

@mscbot mscbot added final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels Jan 23, 2024
@mscbot
Copy link
Collaborator

mscbot commented Jan 28, 2024

The final comment period, with a disposition to merge, as per the review above, is now complete.

@mscbot mscbot added finished-final-comment-period and removed disposition-merge final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels Jan 28, 2024
@turt2live turt2live dismissed richvdh’s stale review January 29, 2024 17:49

review on older diff

@turt2live turt2live merged commit c6853af into old_master Jan 29, 2024
@turt2live turt2live deleted the travis/msc/media-content-disposition branch January 29, 2024 17:49
@turt2live turt2live added spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec and removed finished-final-comment-period labels Jan 29, 2024
turt2live added a commit that referenced this pull request Jan 29, 2024
@turt2live @anoadragon453
@dbkr @richvdh
MSC2702: Specifying semantics for Content-Disposition on media (#2702)
209a99a 
* Proposal to introduce sane Content-Disposition semantics

* Update proposals/2702-media-content-disposition.md

Co-authored-by: Andrew Morgan <[email protected]>

* Update for the year 2023

* Clarify thumbnails receiving Content-Disposition header

* Clarify layering

* Update proposals/2702-media-content-disposition.md

Co-authored-by: David Baker <[email protected]>

* Fix wording

* Apply suggestions from code review

Co-authored-by: Richard van der Hoff <[email protected]>

* Clarify wording

* Add clarifying words

* Adjust security section

---------

Co-authored-by: Andrew Morgan <[email protected]>
Co-authored-by: David Baker <[email protected]>
Co-authored-by: Richard van der Hoff <[email protected]>
@turt2live turt2live mentioned this pull request Mar 12, 2024
Closed
23 tasks
@turt2live turt2live mentioned this pull request Mar 19, 2024
Draft
6 tasks
@turt2live
Copy link
Member Author

Spec PR: matrix-org/matrix-spec#1758

@turt2live turt2live self-assigned this Mar 19, 2024
@Kladki Kladki mentioned this pull request May 29, 2024
Draft
@tcpipuk tcpipuk mentioned this pull request Jun 4, 2024
Open
@zecakeh zecakeh mentioned this pull request Jun 21, 2024
Merged
@zecakeh zecakeh mentioned this pull request Sep 5, 2024
Open
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clokep clokep clokep left review comments

@uhoreg uhoreg uhoreg left review comments

@ara4n ara4n ara4n left review comments

@anoadragon453 anoadragon453 anoadragon453 left review comments

@richvdh richvdh richvdh left review comments

@davidegirardi davidegirardi davidegirardi left review comments

@KitsuneRal KitsuneRal KitsuneRal approved these changes

@dbkr dbkr Awaiting requested review from dbkr

Assignees

@turt2live turt2live

Labels
kind:maintenance MSC which clarifies/updates existing spec proposal A matrix spec change proposal spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec
Projects
Spec Core Team Backlog
Status: Requires spec writing
[Temp] SCT MSC intake board
Status: Scheduled - v1.10
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@turt2live @mscbot @richvdh @clokep @dbkr @uhoreg @ara4n @anoadragon453 @KitsuneRal @davidegirardi