Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] MSC2697: Device dehydration #2697
[WIP] MSC2697: Device dehydration #2697
Changes from 2 commits
99a1b8d
30864b5
d452baf
724b809
7687c3b
64af884
b536770
1edb2ac
bf29f50
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens in the case of them providing
restore_device
anddevice_id
? Is device ID ignored?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll clarify this in the text, but basically, if they specify a
device_id
, then it will be used in the event that the dehydrated device is not used.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it possible to break out full examples on this? Creating types for this isn't the easiest thing at the moment (hard to see what it replies with):
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is I think some side effects to expect with verifications and device list management.
A dehydrated device will appear as a regular device in keys/query right?
Should we display them as a regular device in the device list manager? Wouldn't it look suspicious for user with only one login to see 2 devices?
Also what happen when you request a verification to such devices? Does it impacts the self verification process (where we check for existing devices?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The client could tell which device is the dehydrated device by calling
GET /dehydrated_device
and comparing device IDs. Alternatively, (and maybe better) we could make the server throw a flag in theunsigned
portion of the device key object, maybe a"dehydrated": true
.Either way, it would be up to the client to handle the issues that you listed, e.g. by displaying them differently from regular devices, omitting them from verifications, etc.