Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to convert MSC2324 (facilitating early releases of implementations) to reality #2433

Merged
merged 7 commits into from
May 21, 2020

Conversation

turt2live
Copy link
Member

We've been using this in practice for a while now, so we should document it more officially.

MSC: #2324

We've been using this in practice for a while now, so we should document it more officially. 

MSC: #2324
@richvdh
Copy link
Member

richvdh commented Feb 13, 2020

.o( I wonder why https://11724-24998719-gh.circle-artifacts.com/0/scripts/gen/proposals doesn't work )

Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, a few suggestions

specification/proposals_intro.rst Outdated Show resolved Hide resolved
specification/proposals_intro.rst Outdated Show resolved Hide resolved
specification/proposals_intro.rst Outdated Show resolved Hide resolved
specification/proposals_intro.rst Outdated Show resolved Hide resolved
specification/proposals_intro.rst Outdated Show resolved Hide resolved
specification/proposals_intro.rst Outdated Show resolved Hide resolved
specification/proposals_intro.rst Outdated Show resolved Hide resolved
specification/proposals_intro.rst Outdated Show resolved Hide resolved
specification/proposals_intro.rst Outdated Show resolved Hide resolved
specification/proposals_intro.rst Outdated Show resolved Hide resolved
Co-Authored-By: Richard van der Hoff <[email protected]>
@richvdh richvdh self-requested a review March 6, 2020 10:39
@richvdh
Copy link
Member

richvdh commented Mar 7, 2020

sorry, on reflection you probably knew about the outstanding comments so my bumps aren't very helpful :/

@richvdh richvdh removed their request for review March 7, 2020 17:44
@turt2live
Copy link
Member Author

yea, sorry. I didn't have easy access to a useful editor at the time so just left some comments and reactions to flag that there's still more editing work to be done.

@turt2live
Copy link
Member Author

@richvdh apologies for the massive delay on this - should be ready to review again.

@turt2live turt2live requested a review from richvdh May 15, 2020 19:50
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beyond the suggestions below to address various nits, this feels like an improvement that we should definitely land.

I do think that there's more work to be done here in clarification. Though I very much appreciate the time and effort from @turt2live in writing this up, I don't really feel like the document fits together well as a whole or makes clear reading: in particular it's unclear how the new section relates to the existing "Process" section, since there seems to be significant overlap.

Still, let's land this and aim to iterate rather than waiting for perfection.

specification/proposals_intro.rst Outdated Show resolved Hide resolved
specification/proposals_intro.rst Outdated Show resolved Hide resolved
specification/proposals_intro.rst Outdated Show resolved Hide resolved
specification/proposals_intro.rst Outdated Show resolved Hide resolved
Co-authored-by: Richard van der Hoff <[email protected]>
@turt2live
Copy link
Member Author

I do think that there's more work to be done here in clarification. Though I very much appreciate the time and effort from @turt2live in writing this up, I don't really feel like the document fits together well as a whole or makes clear reading: in particular it's unclear how the new section relates to the existing "Process" section, since there seems to be significant overlap.

Yes, the whole page is in desperate need of someone giving it some love. One of the challenges was trying to figure out where to put this without editing the rest of the doc, and hopefully 'process' is moderately on the right track.

@turt2live turt2live requested a review from richvdh May 20, 2020 23:48
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@turt2live turt2live merged commit 899db41 into master May 21, 2020
@turt2live turt2live deleted the travis/spec/msc2324-early-releases branch May 21, 2020 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants