Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment out the timestamp massaging section for now #1586

Merged
merged 2 commits into from
Aug 29, 2018

Conversation

turt2live
Copy link
Member

Rendered: see 'docs' status check


Pending discussion on #1585

@turt2live turt2live requested a review from a team August 28, 2018 20:07
@Half-Shot
Copy link
Contributor

So we are officially taking this feature out for r0?

@turt2live
Copy link
Member Author

Yup. It needs a lot of thought and planning, which means it really should go through a full review cycle. There's no evidence that the API is used in practice beyond experiments from people, however Synapse is likely to maintain support for the feature in the meantime (as a Synapse feature rather than a spec feature).

@Half-Shot
Copy link
Contributor

Yup. It needs a lot of thought and planning, which means it really should go through a full review cycle. There's no evidence that the API is used in practice beyond experiments from people, however Synapse is likely to maintain support for the feature in the meantime (as a Synapse feature rather than a spec feature).

This is all fine, but I'd like a tombstone notice to let people know that it's no longer a thing as far as r0 is concerned when people go looking for it.

@turt2live turt2live mentioned this pull request Aug 29, 2018
11 tasks
Copy link
Contributor

@Half-Shot Half-Shot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@turt2live turt2live removed the request for review from a team August 29, 2018 16:10
@turt2live
Copy link
Member Author

apparently I forgot to actually add you as a reviewer - thank you in any case!

@turt2live turt2live merged commit 73feee5 into matrix-org:master Aug 29, 2018
@turt2live turt2live deleted the travis/as/comment-ts-section branch August 29, 2018 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants