Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glob flavor used for event_match is not clear #3075

Closed
jplatte opened this issue Mar 25, 2021 · 2 comments · Fixed by #3690
Closed

Glob flavor used for event_match is not clear #3075

jplatte opened this issue Mar 25, 2021 · 2 comments · Fixed by #3690
Labels
clarification An area where the spec could do with being more explicit push

Comments

@jplatte
Copy link
Contributor

jplatte commented Mar 25, 2021

Link to problem area: https://matrix.org/docs/spec/client_server/r0.6.1#conditions

Issue

The spec says:

pattern: The glob-style pattern to match against. Patterns with no special glob characters should be treated as having asterisks prepended and appended when testing the condition.

However it doesn't seem like it's specified anywhere what "special glob characters" are, nor what they mean or whether / how they can be escaped. For example * shell globs stop at slashes, but there's often ** as a wildcard that doesn't do that. It also seems like Synapse implements support for [abc], [a-z], [!a-z] as character range wildcards, but not {foo,bar} as "one-of" globs like many / all shells do.

CC #2637
CC ruma/ruma#442 (for the record: current plan is to only support ? and *, without special handling of /)

@jplatte jplatte added the clarification An area where the spec could do with being more explicit label Mar 25, 2021
@richvdh richvdh added the push label Mar 25, 2021
@turt2live
Copy link
Member

#2810 might be suited to fix this

@richvdh
Copy link
Member

richvdh commented Feb 1, 2022

the C-S API uses globs in three places that I know of: moderation polices, server acls, and push rules. The first two are already specified, so I think the "and others" referred to in the subject is the empty set.

@richvdh richvdh changed the title Glob flavor used for event_match and others is not clear Glob flavor used for event_match is not clear Feb 1, 2022
richvdh added a commit that referenced this issue Feb 17, 2022
@richvdh richvdh linked a pull request Mar 1, 2022 that will close this issue
@richvdh richvdh closed this as completed Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarification An area where the spec could do with being more explicit push
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants