feat(sdk): Add SlidingSync::(clear_and_subscribe|unsubscribe)_to_rooms
#6012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6012 +/- ##
==========================================
- Coverage 88.93% 88.93% -0.01%
==========================================
Files 357 357
Lines 99018 99111 +93
Branches 99018 99111 +93
==========================================
+ Hits 88062 88143 +81
- Misses 6981 6988 +7
- Partials 3975 3980 +5 ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
|
Hywan
force-pushed
the
feat-sdk-sliding-sync-room-unsubscriptions
branch
from
b919900 to
48e7f03
Compare
Hywan
requested review from
jmartinesp and
poljar
and removed request for
a team and
poljar
jmartinesp
approved these changes
Jan 9, 2026
Contributor
jmartinesp
left a comment
jmartinesp
left a comment
There was a problem hiding this comment.
The code LGTM and works really well when tested in Element X Android, thanks!
…ms`. This patch adds two methods on `SlidingSync`: `unsubscribe_to_rooms` and `clear_and_subscribe_to_rooms` to respectively remove many room subscriptions, and to replace room subscriptions by new ones.
…tions. This patch changes `subscribe_to_rooms` in `RoomListService` to replace the old subscriptions. It avoids accumulating subscriptions forever and is closer to the old `visible_rooms` sliding sync list behaviour.
Hywan
force-pushed
the
feat-sdk-sliding-sync-room-unsubscriptions
branch
from
d3f9eca to
4773977
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build on top of #6009.
This patch adds two methods on
SlidingSync:unsubscribe_to_roomsandclear_and_subscribe_to_roomsto respectively remove many room subscriptions, and to replace room subscriptions by new ones