-
Notifications
You must be signed in to change notification settings - Fork 358
feat(ffi): Add IndexedDB and in-memory session stores support #5811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5811 +/- ##
=======================================
Coverage 88.50% 88.50%
=======================================
Files 360 360
Lines 100723 100723
Branches 100723 100723
=======================================
+ Hits 89141 89142 +1
Misses 7398 7398
+ Partials 4184 4183 -1 ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #5811 will not alter performanceComparing Summary
|
poljar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I would perhaps remove the session_ prefix from the various functions and just call it ClientBuilder::sqlite_store() or something along those lines.
I don't think the deprecated warning passes over the FFI, but don't mind it either.
This patch introduces the `sqlite` and `indexeddb` feature flag, enabling the use of SQLite or IndexedDB for the stores. This patch also introduces the ability to use non-persistent, in-memory stores. The new `ClientBuilder::in_memory_store`, `ClientBuilder::sqlite_store` and `ClientBuilder::indexeddb_store` methods are introduced to configure the stores. This patch adds new `SqliteStoreBuilder` and `IndexedDbStoreBuilder` structure.
These two methods are used only once, it's fine to get a large error here.
This method restores and marks `ClientBuilder::session_paths` as deprecated.
|
Thanks for the renaming suggestion. Here are the new names:
|
Looking good. |
This is a reboot of #5245.
This patch introduces the
sqliteandindexeddbfeature flag, enabling the use of SQLite or IndexedDB for the session store. This patch also introduces the ability to use non-persistent, in-memory session store.The new
ClientBuilder::session_store_in_memory,ClientBuilder::session_store_with_sqliteandClientBuilder::session_store_with_indexeddbmethods are introduced to configure the session store. This patch adds newSqliteSessionStoreBuilderandIndexedDbSessionStoreBuilderstructure.