-
Notifications
You must be signed in to change notification settings - Fork 351
sdk: Improvements and fixes around media APIs #5516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…enticated media Signed-off-by: Kévin Commaille <[email protected]>
…ia endpoints too There is no reason to treat them differently. Signed-off-by: Kévin Commaille <[email protected]>
…etch_max_upload_size Signed-off-by: Kévin Commaille <[email protected]>
CodSpeed Performance ReportMerging #5516 will not alter performanceComparing Summary
|
stefanceriu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, thank you Kevin! 👍
Signed-off-by: Kévin Commaille <[email protected]>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5516 +/- ##
==========================================
+ Coverage 88.57% 88.58% +0.01%
==========================================
Files 339 339
Lines 93627 93660 +33
Branches 93627 93660 +33
==========================================
+ Hits 82927 82968 +41
+ Misses 6565 6559 -6
+ Partials 4135 4133 -2 ☔ View full report in Codecov by Sentry. |
|
All right, I fixed the CI. |
|
Beautiful, thank you! |
This includes 3 small commits:
read_timeoutfor HTTP requests, maketimeoutoptional #5437, the request timeout was ignored in media requests, however that didn't apply to unauthenticated media endpoints because they didn't use the modified request config. This fixes it.