feat(common): add the Thread variant to OwnedLinkedChunkId and LinkedChunkId#5445
Merged
feat(common): add the Thread variant to OwnedLinkedChunkId and LinkedChunkId#5445
Thread variant to OwnedLinkedChunkId and LinkedChunkId#5445Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5445 +/- ##
========================================
Coverage 88.89% 88.89%
========================================
Files 333 333
Lines 91884 92009 +125
Branches 91884 92009 +125
========================================
+ Hits 81677 81791 +114
- Misses 6376 6387 +11
Partials 3831 3831 ☔ View full report in Codecov by Sentry. |
d42097d to
005bbd1
Compare
poljar
approved these changes
Jul 24, 2025
Contributor
poljar
left a comment
There was a problem hiding this comment.
Looks good, let us just add an changelog entry.
…OwnedLinkedChunkId`
…m, in find_event and find_event_with_relations of the memory store
005bbd1 to
59c63ab
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should make it clearer what's the expected behavior for the IDB implementation of the event cache. Also, testing is good, because this was actually incorrectly implemented in the memory store.
I've added it in the IDB implementation as well, because I think it should fail (and can't run the IDB tests locally for some reason). [edit] Yes, it did fail, so I've removed it from this PR; someone can investigate it later.
Part of #5122, so part of #4869 too.