Skip to content

feat(common): add the Thread variant to OwnedLinkedChunkId and LinkedChunkId#5445

Merged
bnjbvr merged 4 commits intomainfrom
bnjbvr/thread-linked-chunk-id
Jul 28, 2025
Merged

feat(common): add the Thread variant to OwnedLinkedChunkId and LinkedChunkId#5445
bnjbvr merged 4 commits intomainfrom
bnjbvr/thread-linked-chunk-id

Conversation

@bnjbvr
Copy link
Member

@bnjbvr bnjbvr commented Jul 24, 2025

This should make it clearer what's the expected behavior for the IDB implementation of the event cache. Also, testing is good, because this was actually incorrectly implemented in the memory store.

I've added it in the IDB implementation as well, because I think it should fail (and can't run the IDB tests locally for some reason). [edit] Yes, it did fail, so I've removed it from this PR; someone can investigate it later.

Part of #5122, so part of #4869 too.

@bnjbvr bnjbvr requested a review from a team as a code owner July 24, 2025 12:58
@bnjbvr bnjbvr requested review from poljar and removed request for a team July 24, 2025 12:58
@codecov
Copy link

codecov bot commented Jul 24, 2025

Codecov Report

❌ Patch coverage is 98.52941% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.89%. Comparing base (ca89700) to head (59c63ab).
⚠️ Report is 4 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/matrix-sdk-common/src/linked_chunk/mod.rs 83.33% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main    #5445    +/-   ##
========================================
  Coverage   88.89%   88.89%            
========================================
  Files         333      333            
  Lines       91884    92009   +125     
  Branches    91884    92009   +125     
========================================
+ Hits        81677    81791   +114     
- Misses       6376     6387    +11     
  Partials     3831     3831            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bnjbvr bnjbvr force-pushed the bnjbvr/thread-linked-chunk-id branch 2 times, most recently from d42097d to 005bbd1 Compare July 24, 2025 13:18
Copy link
Contributor

@poljar poljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let us just add an changelog entry.

@bnjbvr bnjbvr force-pushed the bnjbvr/thread-linked-chunk-id branch from 005bbd1 to 59c63ab Compare July 28, 2025 08:21
@bnjbvr bnjbvr enabled auto-merge (rebase) July 28, 2025 08:21
@bnjbvr bnjbvr merged commit 27a002c into main Jul 28, 2025
44 checks passed
@bnjbvr bnjbvr deleted the bnjbvr/thread-linked-chunk-id branch July 28, 2025 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants