Skip to content

Conversation

@Hywan
Copy link
Member

@Hywan Hywan commented Jul 15, 2025

This patch reverts #5407.

It must be merged once #5411 is merged!

@Hywan Hywan requested a review from a team as a code owner July 15, 2025 14:01
@Hywan Hywan requested review from poljar and removed request for a team July 15, 2025 14:01
@codecov
Copy link

codecov bot commented Jul 15, 2025

Codecov Report

Attention: Patch coverage is 78.92720% with 55 lines in your changes missing coverage. Please review.

Project coverage is 88.81%. Comparing base (c5f2460) to head (189832e).
Report is 27 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/matrix-sdk/src/event_cache/room/mod.rs 79.52% 38 Missing and 5 partials ⚠️
crates/matrix-sdk/src/event_cache/room/events.rs 76.47% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5412      +/-   ##
==========================================
- Coverage   88.84%   88.81%   -0.03%     
==========================================
  Files         334      334              
  Lines       91015    91256     +241     
  Branches    91015    91256     +241     
==========================================
+ Hits        80861    81051     +190     
- Misses       6341     6390      +49     
- Partials     3813     3815       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bnjbvr bnjbvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay

@bnjbvr bnjbvr merged commit 7c8f870 into matrix-org:main Jul 22, 2025
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants