Skip to content

feat(sqlite): SqliteEventCacheStore has 1 write connection #5382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Hywan merged 9 commits into from
Jul 14, 2025
Merged

feat(sqlite): SqliteEventCacheStore has 1 write connection #5382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
01641cb
feat(sqlite): `SqliteStoreConfig::pool_size` sets a minimum to 2.
Hywan Jul 9, 2025
e854a56
feat(sqlite): `SqliteEventCacheStore` has 1 write connection.
Hywan Jul 9, 2025
fc21286
feat(sqlite): Add logs around `read` and `write`.
Hywan Jul 13, 2025
7a87580
feat(common): `TracingTimer` uses the `Debug` impl of `Duration`.
Hywan Jul 13, 2025
a5d88d9
refator(common): Rename `TracingTimer::new_debug`.
Hywan Jul 13, 2025
6f932a9
feat(sqlite): Add `timer!` tracings in `read` and `write`'s `SqliteEv…
Hywan Jul 13, 2025
0f08631
feat(sqlite): Add `#[instrument]` around all `SqliteEventCacheStore` …
Hywan Jul 13, 2025
e296f9d
feat(sqlite): Instrument `SqliteEventCacheStore::open_with_config`.
Hywan Jul 13, 2025
fd73cb3
feat(sqlite): Add more `timer!` logs in each `EventCacheStore` methods.
Hywan Jul 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions crates/matrix-sdk-common/src/tracing_timer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ impl std::fmt::Debug for TracingTimer {

impl Drop for TracingTimer {
fn drop(&mut self) {
let message = format!("{} finished in {}ms", self.id, self.start.elapsed().as_millis());
let message = format!("_{}_ finished in {:?}", self.id, self.start.elapsed());

let enabled = tracing::level_enabled!(self.level) && {
let interest = self.callsite.interest();
Expand Down Expand Up @@ -62,12 +62,8 @@ impl Drop for TracingTimer {
}

impl TracingTimer {
/// Create a new `TracingTimer` at the `debug` log level.
pub fn new_debug(
callsite: &'static DefaultCallsite,
id: String,
level: tracing::Level,
) -> Self {
/// Create a new `TracingTimer`.
pub fn new(callsite: &'static DefaultCallsite, id: String, level: tracing::Level) -> Self {
Self { id, callsite, start: Instant::now(), level }
}
}
Expand Down Expand Up @@ -111,7 +107,7 @@ macro_rules! timer {
fields: []
};

$crate::tracing_timer::TracingTimer::new_debug(&__CALLSITE, $string.into(), $level)
$crate::tracing_timer::TracingTimer::new(&__CALLSITE, $string.into(), $level)
}};

($string:expr) => {
Expand All @@ -133,7 +129,7 @@ mod tests {
let _timer_guard = timer!(tracing::Level::DEBUG, "test");
tokio::time::sleep(ruma::time::Duration::from_millis(123)).await;
// Displays: 2023-08-25T15:18:31.169498Z DEBUG
// matrix_sdk_common::tracing_timer::tests: test finished in
// matrix_sdk_common::tracing_timer::tests: _test_ finished in
// 124ms
}
}
Expand Down
Loading
Loading