Update README to make Element sponsorship explicit #5341
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #5341 +/- ##
=======================================
Coverage 88.76% 88.77%
=======================================
Files 333 333
Lines 90228 90228
Branches 90228 90228
=======================================
+ Hits 80093 80096 +3
+ Misses 6309 6306 -3
Partials 3826 3826 ☔ View full report in Codecov by Sentry. |
poljar
left a comment
poljar
left a comment
There was a problem hiding this comment.
Now I'm not a designer, but something feels a bit off here 😅.
It would be nice if the new image respects the background color/theme github is using, like the main logo does. It does feel a bit too big as well.
| The Matrix Rust SDK is a collection of libraries that make it easier to build [Matrix] clients in [Rust]. | ||
| <br><br> | ||
| <div align="center"> | ||
| <picture> | ||
| <source srcset="contrib/element-logo-light.png" media="(prefers-color-scheme: dark)"> | ||
| <source srcset="contrib/element-logo-dark.png" media="(prefers-color-scheme: light)"> | ||
| <img src="contrib/element-logo-fallback.png" alt="Element logo"> | ||
| </picture> | ||
| </div> | ||
| <br><br> | ||
| Development of the SDK is proudly sponsored and maintained by [Element](https://element.io). Element uses the SDK in their next-generation mobile apps Element X on [iOS](https://github.com/element-hq/element-x-ios) and [Android](https://github.com/element-hq/element-x-android) and has plans to introduce it to the web and desktop clients as well. | ||
|
|
||
| The SDK is also the basis for multiple Matrix projects and we welcome contributions from all. |
There was a problem hiding this comment.
I think that this might look still better if we center the whole section, or at least the first paragraph. As it is now, we have a left/center/left scenario making the logo still look a bit out of place.
There was a problem hiding this comment.
Yeah I like that, done
poljar
left a comment
poljar
left a comment
There was a problem hiding this comment.
Alright, seems good. Thanks for taking the time to tweak this.
2 participants
No description provided.