Skip to content

Conversation

@jplatte
Copy link
Collaborator

@jplatte jplatte commented Jun 27, 2025

Process:

  • set style_edition to 2024 in .rustfmt.toml
  • run cargo fmt
  • undo .rustfmt.toml change
  • run cargo fmt again
  • manually rewrap some strings

Should be much less likely to conflict with other PRs than #5255, and reduces the diff of the next iteration of that PR a little.

Signed-off-by: Jonas Platte

Process:
- set style_edition to 2024 in .rustfmt.toml
- run `cargo fmt`
- undo .rustfmt.toml change
- run `cargo fmt` again
- manually rewrap some strings
@jplatte jplatte requested review from a team as code owners June 27, 2025 17:25
@jplatte jplatte requested review from andybalaam and removed request for a team June 27, 2025 17:26
@codecov
Copy link

codecov bot commented Jun 27, 2025

Codecov Report

Attention: Patch coverage is 25.92593% with 40 lines in your changes missing coverage. Please review.

Project coverage is 88.70%. Comparing base (ca99977) to head (464ae1c).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crates/matrix-sdk-base/src/latest_event.rs 0.00% 4 Missing ⚠️
crates/matrix-sdk-common/src/linked_chunk/mod.rs 33.33% 4 Missing ⚠️
crates/matrix-sdk-base/src/room/knock.rs 0.00% 3 Missing ⚠️
...es/matrix-sdk-common/src/deserialized_responses.rs 0.00% 3 Missing ⚠️
...rix-sdk-ui/src/timeline/controller/aggregations.rs 0.00% 3 Missing ⚠️
...rates/matrix-sdk-ui/src/timeline/controller/mod.rs 40.00% 3 Missing ⚠️
...dk-ui/src/timeline/controller/state_transaction.rs 25.00% 3 Missing ⚠️
crates/matrix-sdk/src/encryption/mod.rs 0.00% 3 Missing ⚠️
crates/matrix-sdk/src/event_cache/room/mod.rs 0.00% 3 Missing ⚠️
crates/matrix-sdk-crypto/src/identities/manager.rs 0.00% 2 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5303      +/-   ##
==========================================
- Coverage   88.71%   88.70%   -0.02%     
==========================================
  Files         330      330              
  Lines       88773    88799      +26     
  Branches    88773    88799      +26     
==========================================
+ Hits        78759    78767       +8     
- Misses       6208     6234      +26     
+ Partials     3806     3798       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@poljar poljar merged commit 3d64235 into main Jun 27, 2025
44 checks passed
@poljar poljar deleted the jplatte/fmt-cleanup branch June 27, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants