chore(sdk): Rename RoomEventCacheListener to RoomEventCacheSubscriber#5269
Merged
Hywan merged 5 commits intomatrix-org:mainfrom Jun 23, 2025
Merged
Conversation
This patch renames a variable to match the `EventCacheDropHandles` field's name.
This patch renames `tx` and `rx` to `auto_shrink_sender` and `auto_shrink_receiver` to clarify the code.
…criber`. This patch removes a name ambiguity around _listener_ vs. _subscriber_. Both terms are used to talk about `RoomEventCacheListener`. We usually use the term _subscriber_ for the type being returned by a `subscribe` method. The code refers to this sometimes as listener, sometimes as subscriber, sometimes both in the same sentence, which can be very confusing! This patch solves this by using the _subscriber_ term only.
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #5269 +/- ##
==========================================
+ Coverage 90.18% 90.20% +0.01%
==========================================
Files 334 334
Lines 104822 104825 +3
Branches 104822 104825 +3
==========================================
+ Hits 94535 94557 +22
+ Misses 6235 6216 -19
Partials 4052 4052 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #5247.
This patch removes a name ambiguity around listener vs. subscriber.
Both terms are used to talk about
RoomEventCacheListener. We usuallyuse the term subscriber for the type being returned by a
subscribemethod. The code refers to this sometimes as listener, sometimes
as subscriber, sometimes both in the same sentence, which can be very
confusing! This patch solves this by using the subscriber term only.
Moreover, the term listener refers to a callback (usually a function) that is
passed to an event-based or reactive system, like we have in
matrix_sdk_ffifor example. It's not appropriate here.