Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Client::login_with_sso() to be send #518

Merged
merged 2 commits into from
Mar 7, 2022

Conversation

jsparber
Copy link
Contributor

@jsparber jsparber commented Mar 7, 2022

This removes the info!() log because of
rust-lang/rust#93274

This removes the `info!()` log because of
rust-lang/rust#93274
Copy link
Contributor

@poljar poljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want to remove those log lines.

crates/matrix-sdk/src/client.rs Show resolved Hide resolved
crates/matrix-sdk/src/client.rs Show resolved Hide resolved
crates/matrix-sdk/src/client.rs Show resolved Hide resolved
We can't use `.await` inside `info!()` because of
rust-lang/rust#93274
@jsparber jsparber requested a review from poljar March 7, 2022 13:16
Copy link
Contributor

@poljar poljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@poljar poljar merged commit 6dff065 into matrix-org:main Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants