Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(oidc): Start replacing mas-oidc-client with oauth2 #4761

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

zecakeh
Copy link
Collaborator

@zecakeh zecakeh commented Mar 5, 2025

This makes use of the oauth2 crate for the authorization code grant and the refresh token grant.

There is still the token revocation that can use oauth2, but it requires changes in the HTTP client so it will be done separately. And the remaining parts (account management URL, fallback discovery, registration) will need to be included in the SDK to get rid of mas-oidc-client.

@zecakeh zecakeh requested a review from a team as a code owner March 5, 2025 16:00
@zecakeh zecakeh requested review from stefanceriu and poljar and removed request for a team and stefanceriu March 5, 2025 16:00
Copy link

codecov bot commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 91.02564% with 7 lines in your changes missing coverage. Please review.

Project coverage is 86.28%. Comparing base (6c9b1ef) to head (6b004bc).

Files with missing lines Patch % Lines
crates/matrix-sdk/src/authentication/oidc/error.rs 62.50% 3 Missing ⚠️
crates/matrix-sdk/src/authentication/oidc/mod.rs 93.75% 3 Missing ⚠️
...matrix-sdk/src/authentication/oidc/qrcode/login.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4761      +/-   ##
==========================================
+ Coverage   86.26%   86.28%   +0.01%     
==========================================
  Files         290      291       +1     
  Lines       34286    34291       +5     
==========================================
+ Hits        29578    29587       +9     
+ Misses       4708     4704       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant