feat(ui): RoomListService re-enables share_pos
#4741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4741 +/- ##
=======================================
Coverage 86.14% 86.15%
=======================================
Files 292 292
Lines 34295 34295
=======================================
+ Hits 29544 29547 +3
+ Misses 4751 4748 -3 ☔ View full report in Codecov by Sentry. |
bnjbvr
requested changes
Mar 3, 2025
Do you want me to test on android first? |
Yes please, that would be amazing 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
The idea is the following: if we keep the sliding sync
pos, first off, the homeservers will be happier because they don't have to re-compute a session every time, and second, the overall user experience may be better as we receive much lesslimitedresponses from the homeservers.I don't know why it was creating slowness at some moment. My hope it that the problem has resolved by itself because many refactorings happened since then 🤞.