fix(ui): Fix latest_edit_json for live edits
#4552
Open
+24
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zecakeh
changed the title
latest_edit_json for live edits
zecakeh
force-pushed
the
fix-live-edit-json
branch
from
c3c436c to
a23393b
Compare
This was a regression introduced in f0d9860. `latest_edit_json` was first set by the call to `EventTimelineItem::with_content()`. It was overwritten in the next section because of the `if let EventTimelineItemKind::Remote(remote_event)` that uses `item` instead of `new_item`. It means that the updated `RemoteEventTimelineItem` inside`new_item` was replaced by the outdated one inside `item`, so `latest_edit_json` goes back to its previous value. I believe that part of why that went unnoticed is that the code looks more complicated due to the need to set an inner field, so I decided to change the API and move `with_encryption_info` to `EventTimelineItem`, which makes the code look cleaner. Signed-off-by: Kévin Commaille <[email protected]>
zecakeh
force-pushed
the
fix-live-edit-json
branch
from
a23393b to
9b351e4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4552 +/- ##
==========================================
- Coverage 85.39% 85.38% -0.01%
==========================================
Files 285 285
Lines 32213 32215 +2
==========================================
- Hits 27509 27508 -1
- Misses 4704 4707 +3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a regression introduced in f0d9860.
latest_edit_jsonwas first set by the call toEventTimelineItem::with_content(). It was overwritten in the next section because of theif let EventTimelineItemKind::Remote(remote_event)that usesiteminstead ofnew_item.It means that the updated
RemoteEventTimelineIteminsidenew_itemwas replaced by the outdated one insideitem, solatest_edit_jsonwent back to its previous value.I believe that part of why that went unnoticed is that the code looks more complicated due to the need to set an inner field dependant on an enum variant, so I decided to change the API and move
with_encryption_infotoEventTimelineItem, which makes the code look cleaner.The changes in the tests fail without this commit.