Tiny collection of tiny small edits around Sliding Sync #3830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch asserts that when subscribing to a new room, the old room subscriptions are still present. Is it the behaviour we want? Probably not, but this is the standard behaviour right now, and we need to assert it.
…data`. This patch changes the visibility of `SlidingSyncList::invalidate_sticky_data` from `pub` to `pub(super)`. This is the only place where it must be accessible from.
bnjbvr
approved these changes
Aug 12, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3830 +/- ##
=======================================
Coverage 84.13% 84.13%
=======================================
Files 263 263
Lines 27592 27593 +1
=======================================
+ Hits 23214 23215 +1
Misses 4378 4378 ☔ View full report in Codecov by Sentry. |
This patch adds a `trace` log for `must_process_rooms_response`. That's useful for debugging weird bugs.
Even if the visual output is the same, it's semantically better to have `<a><code>…</code></a>` rather than `<code><a>…</a></code>` I believe.
Hywan
force-pushed
the
chore-sdk-sliding-sync-room-subscriptions-various
branch
from
b8230d4 to
fe01f13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a tiny collection of really small patches I've done while trying to debug bugs about the sliding sync native implementation.