Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FFI: Allow restoring an existing session with SSS enabled. #3723

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

pixlwave
Copy link
Member

Small follow-up to #3676 that makes 2 small changes:

  • Ignore a Session's sliding sync proxy when restoring a client in the FFI so we don't have to do it in both EXI and EXA.
  • Ignore a custom sliding sync proxy when building a client with support for SSS (not tested that one specifically but seemed worth adding whilst writing the other one).

@pixlwave pixlwave requested a review from a team as a code owner July 17, 2024 16:21
@pixlwave pixlwave requested review from Hywan and removed request for a team July 17, 2024 16:21
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.01%. Comparing base (dd20c37) to head (e644cb4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3723   +/-   ##
=======================================
  Coverage   84.01%   84.01%           
=======================================
  Files         260      260           
  Lines       26700    26700           
=======================================
  Hits        22432    22432           
  Misses       4268     4268           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Hywan Hywan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me. Thanks!

@Hywan Hywan merged commit 4bbb6bd into main Jul 18, 2024
40 checks passed
@Hywan Hywan deleted the doug/ffi-restore-sss branch July 18, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants