fix(sdk): Sliding sync rooms aren't restored from the cache #3702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch updates a test to ensure that rooms are restored correctly by the sliding sync cache. This test fails :-].
This patch fixes a bug where rooms stored in the sliding sync cache aren't restored by the `SlidingSyncBuilder`. This patch also removes `SlidingSyncBuilder::rooms` fields which was used but never modified. It's dead code.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3702 +/- ##
==========================================
- Coverage 84.37% 84.37% -0.01%
==========================================
Files 258 258
Lines 26656 26655 -1
==========================================
- Hits 22492 22490 -2
- Misses 4164 4165 +1 ☔ View full report in Codecov by Sentry. |
bnjbvr
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes a bug where rooms stored in the sliding sync cache aren't restored by the
SlidingSyncBuilder.This patch also improves a test to ensure we don't break this in the future again.