indexeddb: Clear the object store before deleting it #3090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andybalaam
changed the title
Since my investigation found that it significantly speeds up deletion of a store on both Firefox and Chromium if you clear() it first, do that in our migration code.
andybalaam
force-pushed
the
andybalaam/indexeddb-clear-store-before-delete
branch
from
124c9eb to
916e85f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3090 +/- ##
=======================================
Coverage 83.71% 83.71%
=======================================
Files 224 224
Lines 23497 23497
=======================================
Hits 19671 19671
Misses 3826 3826 ☔ View full report in Codecov by Sentry. |
andybalaam
added a commit
to matrix-org/matrix-rust-sdk-crypto-wasm
that referenced
this pull request
Feb 5, 2024
Including getting the latest matrix-rust-sdk, providing: * [indexeddb: Clear the object store before deleting it #3090](matrix-org/matrix-rust-sdk#3090) which speeds up the schema upgrade v8 to v10 (see element-hq/element-web#26948 ).
Hywan
reviewed
Feb 5, 2024
| @@ -317,6 +317,11 @@ async fn prepare_data_for_v7(serializer: &IndexeddbSerializer, db: &IdbDatabase) | |||
| } | |||
| } | |||
|
|
|||
| // We have finished with the old store. Clear it, since it is faster to | |||
| // clear+delete than just delete. See https://www.artificialworlds.net/blog/2024/02/01/deleting-an-indexed-db-store-can-be-incredibly-slow-on-firefox/ | |||
There was a problem hiding this comment.
Seems like the author of the blog is to blame: https://www.artificialworlds.net/blog/2024/02/02/deleting-an-indexed-db-store-can-be-incredibly-slow-on-firefox/.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since my investigation found that it significantly speeds up deletion of a store on both Firefox and Chromium if you clear() it first, do that in our migration code.
Related: element-hq/element-web#26948