Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove an expensive database call only used for tracing prupose #2977

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

BillCarsonFr
Copy link
Member

mark_request_as_sent of the BackupMachine was doing a call to store_inbound_group_session_count just for tracing purpose.
On a test setup with 100k room keys, this call to count is taking 1955ms, in comparison mark_inbound_group_sessions_as_backed_up is taking 300ms.
It's making mark as sent for backup take long for nothing

  • Public API changes documented in changelogs (optional)

Signed-off-by:

@BillCarsonFr BillCarsonFr requested a review from a team as a code owner December 22, 2023 15:24
@BillCarsonFr BillCarsonFr requested review from bnjbvr and removed request for a team December 22, 2023 15:24
Copy link
Member

@bnjbvr bnjbvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For performance improvements, please provide a benchmark in a separate commit, a run before the patch, and a run after the patch. Thanks in advance!

Copy link

codecov bot commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (45bdbf5) 83.41% compared to head (541d918) 83.41%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2977      +/-   ##
==========================================
- Coverage   83.41%   83.41%   -0.01%     
==========================================
  Files         222      222              
  Lines       23150    23149       -1     
==========================================
- Hits        19311    19310       -1     
  Misses       3839     3839              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BillCarsonFr
Copy link
Member Author

For performance improvements, please provide a benchmark in a separate commit, a run before the patch, and a run after the patch. Thanks in advance!

AFAIK there are no benchmark for indexeddb

Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@manuroe manuroe merged commit 3d9d3b7 into main Jan 2, 2024
35 checks passed
@manuroe manuroe deleted the valere/long_mark_as_sent branch January 2, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants