read receipts: don't update a RoomInfo if the read receipts haven't changed
#2968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hywan
approved these changes
Dec 21, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2968 +/- ##
=======================================
Coverage 83.40% 83.40%
=======================================
Files 222 222
Lines 23144 23149 +5
=======================================
+ Hits 19303 19308 +5
Misses 3841 3841 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a TODO from #2953, by returning a boolean indicating whether a change happened in the
RoomReadReceiptsand they do need in fact to be saved.