Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process rooms' read status client-side #2953

Merged
merged 10 commits into from
Dec 21, 2023
Merged

Process rooms' read status client-side #2953

merged 10 commits into from
Dec 21, 2023

Commits on Dec 18, 2023

  1. Configuration menu
    Copy the full SHA
    5b94bd4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cb956d6 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2023

  1. Configuration menu
    Copy the full SHA
    a9da591 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    031d810 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2726725 View commit details
    Browse the repository at this point in the history
  4. read receipts: move the unread messages and mentions counts to separa…

    …te fields of `RoomInfo`
    bnjbvr committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    5602e8c View commit details
    Browse the repository at this point in the history
  5. read receipts: don't clone cached events for computing the read recei…

    …pt state
    
    Before this patch, we needed to clone the inner `timeline_queue` and turn it into a concrete `Vec<SyncTimelineEvent>`, just to iterate on the elements,
    and because returning an iterator from a trait method is impractical. This now changes it to return the actual concrete type of `timeline_queue`, so
    we don't need the extra allocations.
    
    Ideally, matrix-sdk and matrix-sdk-base would be merged, so we don't need to use a trait at all here.
    bnjbvr committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    546637d View commit details
    Browse the repository at this point in the history
  6. read receipts: add an extra num_unread_notifications field

    This helps supporting cases where we want to show that a room has some activity (unread messages) but no notifications.
    bnjbvr committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    e9fe6b8 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2023

  1. Address review comments

    - copyright notice
    - doc comments and better doc in general
    - use static dispatch instead of &dyn T
    - other misc comments
    bnjbvr committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    f989c17 View commit details
    Browse the repository at this point in the history
  2. Disable integration test in code coverage build

    The test fails only in the codecov build, not in a local build or in the other integration test.
    
    Needs further investigation.
    bnjbvr committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    85ddfb0 View commit details
    Browse the repository at this point in the history