Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ffi: with_mentions method #2727

Merged
merged 1 commit into from
Oct 18, 2023
Merged

ffi: with_mentions method #2727

merged 1 commit into from
Oct 18, 2023

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Oct 17, 2023

Can be used to add mentions to the content of a message.

@Velin92 Velin92 marked this pull request as ready for review October 17, 2023 15:40
@Velin92 Velin92 requested a review from a team as a code owner October 17, 2023 15:40
@Velin92 Velin92 requested review from jplatte and removed request for a team October 17, 2023 15:40
@Velin92 Velin92 linked an issue Oct 17, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (7f3fef5) 78.71% compared to head (7099baa) 78.70%.
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2727      +/-   ##
==========================================
- Coverage   78.71%   78.70%   -0.01%     
==========================================
  Files         200      200              
  Lines       20359    20359              
==========================================
- Hits        16025    16023       -2     
- Misses       4334     4336       +2     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jplatte jplatte merged commit 5f0e5c7 into main Oct 18, 2023
54 checks passed
@jplatte jplatte deleted the mauroromito/set_mentions_method branch October 18, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow clients to send intentional mentions
2 participants