feat(ui): Implement RoomList::entries_with_dynamic_filter
#2392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because it makes more sense.
This patch updates the tests to ensure `entries_with_dynamic_filter` works as expected.
These test cases are more easy to understand than the previous one if you ask me.
First, this patch makes `RoomList::entries` infallible. Second, this patch implements `RoomList::entries_with_dynamic_filter`.
This patch implements a new `all` filter.
This patch removes `RoomListEntriesDynamicFilter::set_with_fuzzy_match_pattern` and replaces it by a single `::set` method. It takes a new enum as parameter: `RoomListEntriesDynamicFilterKind`. This enum has a `FuzzyMatchRoomName` variant to simulate the removed method. It also adds the `All` variant, to represent the `all` filter.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2392 +/- ##
==========================================
+ Coverage 77.78% 77.79% +0.01%
==========================================
Files 175 176 +1
Lines 18619 18643 +24
==========================================
+ Hits 14482 14504 +22
- Misses 4137 4139 +2
☔ View full report in Codecov by Sentry. |
jplatte
approved these changes
Aug 9, 2023
| /// Create a new filter that will accept all filled or invalidated entries. | ||
| pub fn new_filter() -> impl Fn(&RoomListEntry) -> bool { | ||
| |room_list_entry| -> bool { | ||
| matches!(room_list_entry, RoomListEntry::Filled(_) | RoomListEntry::Invalidated(_)) |
There was a problem hiding this comment.
I find it weird that this filter is called "all" but still excludes some entries.
There was a problem hiding this comment.
Yeah, that’s a technical details. Empty are always filtered out because they are never rendered.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #1911.
Thanks for @jplatte for his collaboration on this patch.
This patch can be reviewed commit-by-commit, but a one-diff review is also doable I guess.
On FFI side:
RoomList::entriesis now infallible,RoomList::entries_with_dynamic_filterhas been implemented. It returns a stream + aRoomListDynamicFilterobject, which has a single method:set. It acceptsRoomListDynamicFilterKindvalue, which is an enum withAllorFuzzyMatchRoomNamevariants.Why this design? Because it allows the client-app to use
entriesif it provides a single “static” room list, orentries_with_dynamic_filterif it considers to filter the list with various filters. The client-app doesn't have to callentriesorentries_with_dynamic_filteralternatively, it can just switch betweenAllor other variants depending of the filters.On the Rust side:
allfilter, which returnstruefor allRoomListEntrythat areFilledorInvalidated,RoomList::entries_with_dynamic_filtermethod,RoomList::entries_filteredmethod to::entries_with_static_filter.