Update Rust SDK to latest version #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #132 |
richvdh
requested changes
Jul 5, 2024
src/encryption.rs
Outdated
| /// Strategy to collect the devices that should receive room keys for the | ||
| /// current discussion. | ||
| /// | ||
| /// See matrix_sdk_crypto::CollectStrategy |
There was a problem hiding this comment.
Please make these docs stand in their own right, so that the online doc (https://matrix-org.github.io/matrix-rust-sdk-crypto-wasm/classes/OlmMachine.html) is useful. (The fact that there are existing docs that just point to a Rust class is definitely bad.)
Hywan
reviewed
Jul 8, 2024
src/encryption.rs
Outdated
Comment on lines
119
to
121
| #[wasm_bindgen()] | ||
| #[derive(Debug, Clone, PartialEq, Eq)] | ||
| /// Strategy to collect the devices that should receive room keys for the |
There was a problem hiding this comment.
Please put the #[…] after the documentation. It's more Rust idiomatic to do so.
I've added a changelog. I'm not sure what the criteria are for which rust-sdk-crypto changes to highlight in the changelogs, so I just highlighted the one that causes the breaking change. |
richvdh
reviewed
Jul 9, 2024
richvdh
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like three different matrix-rust-sdk PRs introduced incompatible changes. This is my attempt to fix them. I'm certain that the fix for my PR is correct, but fairly sure that the
sender_datafix is correct, and less sure that theCollectStrategyfix is sensible.This introduces a change that will break js-sdk (yay for cascading breakage), so that will need to be updated.
Not sure why the test is failing. Seems to be unrelated to the changes here, so must be some change elsewhere. I'm guessing that it should be fine to update the expected values to the actual values, but someone who knows about why the discrepancy is there should verify.