Rename the QrCodeData methods so they use camel case and update the changelog. #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
reviewed
Jun 13, 2024
CHANGELOG.md
Outdated
| @@ -11,6 +11,10 @@ | |||
| - Use the server name in the `QrCodeData` instead of the homeserver URL. | |||
| ([#3537](https://github.com/matrix-org/matrix-rust-sdk/pull/3537)) | |||
|
|
|||
| - Rename the `QrCodeData.homeserver_url` method to `QrCodeData.server_name` | |||
| to reflect the changed data stored in the QR code. | |||
| ([#124](https://github.com/matrix-org/matrix-rust-sdk-crypto-wasm/pull/124#discussion_r1638479911)) | |||
There was a problem hiding this comment.
This seems like the wrong link? also, it's not part of the update of the rust sdk so needs outdenting.
There was a problem hiding this comment.
Also, if we're breaking the API anyway, it would be nice to fix the names to be camelCase
poljar
changed the title
poljar
force-pushed
the
poljar/update-changelog
branch
from
c0d9fda to
ef80e8f
Compare
|
Rebased to get rid of the fixup commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.