This repository was archived by the owner on Sep 27, 2024. It is now read-only.
Android: Allow pasting of non text content#700
Merged
Conversation
Contributor
langleyd
commented
Jun 1, 2023
- Only special-case onTextContextMenuItem paste behaviour if it is text that is pasted, otherwise default to EditText implementation.
- Add tests for pasting of images, plain text and html
- Only special-case onTextContextMenuItem paste behaviour if it is text that is pasted, otherwise default to EditText implementation. - Add tests for pasting of images, plain text and html
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #700 +/- ##
============================================
- Coverage 88.12% 87.76% -0.36%
- Complexity 272 274 +2
============================================
Files 143 114 -29
Lines 16291 14902 -1389
Branches 762 218 -544
============================================
- Hits 14356 13079 -1277
+ Misses 1753 1656 -97
+ Partials 182 167 -15
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
jonnyandrew
reviewed
Jun 1, 2023
Contributor
jonnyandrew
left a comment
There was a problem hiding this comment.
Looks good to me, just one comment about the UriContentListener
| import androidx.core.view.ContentInfoCompat | ||
| import androidx.core.view.OnReceiveContentListener | ||
|
|
||
| class UriContentListener( |
Contributor
There was a problem hiding this comment.
If this is only used as a test utility, could you move it into the test directory?
(Or if it is supposed to be exposed as a library utility, then we should add some documentation and use it in the example app)
|
Kudos, SonarCloud Quality Gate passed! |
jonnyandrew
approved these changes
Jun 1, 2023
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.







