Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Stop stealing style rules for the options button on ThreadList #8777

Closed
wants to merge 6 commits into from
Closed

Stop stealing style rules for the options button on ThreadList #8777

wants to merge 6 commits into from

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Jun 7, 2022

Before After
before after

The options button on ThreadList does not belong to the message action bar and should have its own style rules. See https://github.com/matrix-org/matrix-react-sdk/blob/3a20cb17038bd8e35b61291ab8eab640f6d333fd/res/css/views/messages/_MessageActionBar.scss for the original rules.

Signed-off-by: Suguru Hirahara [email protected]

type: task


This change is marked as an internal change (Task), so will not be included in the changelog.

@github-actions github-actions bot added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Jun 7, 2022
@luixxiul luixxiul marked this pull request as ready for review June 8, 2022 01:10
@luixxiul luixxiul requested a review from a team as a code owner June 8, 2022 01:10
Signed-off-by: Suguru Hirahara <[email protected]>
@luixxiul
Copy link
Contributor Author

luixxiul commented Jun 8, 2022

The conflict was fixed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants