This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 833
Start adding Cypress tests for crypto #8577
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t3chguy
reviewed
May 13, 2022
t3chguy
reviewed
May 13, 2022
duxovni
added
the
T-Task
Refactoring, enabling or disabling functionality, other engineering tasks
label
May 13, 2022
t3chguy
reviewed
May 13, 2022
Is this another case of the CI system being picky and needing us to be more careful with how we import things? |
t3chguy
reviewed
May 13, 2022
Yes, the way that cypress currently builds the specs is via a webpack which doesn't have the same config as our main webpack so some things don't work the same. We could/should look into tweaking the preprocessor at some point |
t3chguy
reviewed
May 13, 2022
Co-authored-by: Michael Telatynski <[email protected]>
t3chguy
reviewed
May 23, 2022
Does this check off any tasks on element-hq/element-web#7312 |
t3chguy
reviewed
May 27, 2022
t3chguy
approved these changes
May 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is marked as an internal change (Task), so will not be included in the changelog.