Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Start adding Cypress tests for crypto #8577

Merged
merged 14 commits into from
May 30, 2022
Merged

Start adding Cypress tests for crypto #8577

merged 14 commits into from
May 30, 2022

Conversation

duxovni
Copy link
Contributor

@duxovni duxovni commented May 13, 2022


This change is marked as an internal change (Task), so will not be included in the changelog.

@duxovni duxovni requested a review from a team as a code owner May 13, 2022 08:39
@duxovni duxovni added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label May 13, 2022
@duxovni
Copy link
Contributor Author

duxovni commented May 13, 2022

Error: Webpack Compilation Error
./node_modules/matrix-js-sdk/src/utils.ts 26:12
Module parse failed: Unexpected token (26:12)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
| import promiseRetry from "p-retry";
| 
> import type * as NodeCrypto from "crypto";
| import { MatrixEvent } from ".";
| import { M_TIMESTAMP } from "./@types/location";
 @ ./node_modules/matrix-js-sdk/src/store/session/webstorage.js 24:0-37 41:9-25 42:9-25 43:9-25 44:9-25
 @ ./cypress/support/bot.ts
 @ ./cypress/support/index.ts

Is this another case of the CI system being picky and needing us to be more careful with how we import things?

cypress/support/bot.ts Outdated Show resolved Hide resolved
@t3chguy
Copy link
Member

t3chguy commented May 13, 2022

Yes, the way that cypress currently builds the specs is via a webpack which doesn't have the same config as our main webpack so some things don't work the same. We could/should look into tweaking the preprocessor at some point

cypress/support/storage.ts Outdated Show resolved Hide resolved
Co-authored-by: Michael Telatynski <[email protected]>
cypress/integration/6-crypto/crypto.spec.ts Outdated Show resolved Hide resolved
cypress/integration/6-crypto/crypto.spec.ts Outdated Show resolved Hide resolved
cypress/integration/6-crypto/crypto.spec.ts Outdated Show resolved Hide resolved
@t3chguy
Copy link
Member

t3chguy commented May 26, 2022

Does this check off any tasks on element-hq/element-web#7312

Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@duxovni duxovni merged commit 5b520e8 into develop May 30, 2022
@duxovni duxovni deleted the cypress-crypto branch May 30, 2022 13:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants