Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Hide the verification left stroke only on the thread list #8525

Merged
merged 3 commits into from
May 11, 2022
Merged

Hide the verification left stroke only on the thread list #8525

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
577239f
Hide the verification left stroke only in the thread panel (ie. let i…
luixxiul May 7, 2022
5973d82
Display the left stroke inside a thread
luixxiul May 10, 2022
5825b18
Merge branch 'develop' into EventTile_ThreadsList
luixxiul May 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion res/css/views/right_panel/_ThreadPanel.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ limitations under the License.
}

&:hover .mx_EventTile_line {
box-shadow: unset !important; // don't show the verification left stroke in the thread list
box-shadow: inherit; // let the verification left stroke shown in the chat panel with a maximized widget
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is ThreadPanel (i.e the list of threads) here the stroke shouldn't be shown

Copy link
Contributor Author

@luixxiul luixxiul May 10, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The line was changed so that the left stroke would be displayed only in the chat panel, which is no longer the case, so I am going to just remove it.

The catch here is that mx_ThreadPanel class name is added to the chat panel with a maximized widget (mx_TimelineCard) as well.

before

This is a bug which should be fixed, whether incrementally or all at once.

}

Expand Down
20 changes: 17 additions & 3 deletions res/css/views/rooms/_EventTile.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -723,12 +723,22 @@ $threadInfoLineHeight: calc(2 * $font-12px); // See: _commons.scss
flex-flow: wrap;
align-items: center;

&:hover,
// To cancel "&.mx_EventTile:hover .mx_EventTile_line"
&:not([data-layout=bubble]):hover .mx_EventTile_line {
&:hover {
background-color: $system;
}

// To cancel "&.mx_EventTile:hover .mx_EventTile_line"
&:not([data-layout=bubble]):hover {
.mx_EventTile_line {
background-color: $system;
}

// Override .mx_EventTile:not([data-layout=bubble]):hover.mx_EventTile_verified .mx_EventTile_line
&.mx_EventTile_verified .mx_EventTile_line {
box-shadow: none; // don't show the verification left stroke in the thread list (data-shape=ThreadsList)
}
}

&::after {
content: "";
position: absolute;
Expand Down Expand Up @@ -850,6 +860,10 @@ $threadInfoLineHeight: calc(2 * $font-12px); // See: _commons.scss

&:not([data-layout=bubble]) {
padding-top: $spacing-16;

&:hover .mx_EventTile_line {
box-shadow: none; // don't show the verification left stroke in a thread (mx_ThreadView)
}
t3chguy marked this conversation as resolved.
Show resolved Hide resolved
}
}

Expand Down