Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

unit test basic paths in UserInfo #7740

Merged
merged 3 commits into from
Feb 8, 2022
Merged

Conversation

kerryarchibald
Copy link
Contributor

@kerryarchibald kerryarchibald commented Feb 8, 2022

#7687


This change is marked as an internal change (Task), so will not be included in the changelog.

Preview: https://62025dd78d8a9ab0a84b53fb--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

Kerry Archibald added 2 commits February 8, 2022 11:58
Signed-off-by: Kerry Archibald <[email protected]>
@kerryarchibald kerryarchibald added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Feb 8, 2022
@kerryarchibald kerryarchibald requested a review from a team as a code owner February 8, 2022 11:01

it('renders user info', () => {
const component = getComponent();
expect(component.find(BasicUserInfo).length).toBeTruthy();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use "BasicUserInfo" instead of having to export it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea, done

Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than exporting a component only for tests when you can find components by name too

Signed-off-by: Kerry Archibald <[email protected]>
@kerryarchibald kerryarchibald enabled auto-merge (squash) February 8, 2022 12:07
@kerryarchibald kerryarchibald merged commit 30d1ac1 into develop Feb 8, 2022
@kerryarchibald kerryarchibald deleted the 7687/test-userinfo branch February 8, 2022 12:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants