This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 833
Fix vertical spacing in compact
<ContextMenu>
#7684
Merged
MadLittleMods
merged 4 commits into
develop
from
madlittlemods/20801-fix-context-compact-context-menu-vertical-spacing
Feb 1, 2022
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
4dc9ef9
Fix vertical spacing in compact context menus
MadLittleMods aefe13f
Make sure we pass along the other classes passed in like mx_IconizedC…
MadLittleMods f0b0985
Document where these magic values come from
MadLittleMods 1d6abea
Fix lints
MadLittleMods File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -193,7 +193,6 @@ export default class DateSeparator extends React.Component<IProps, IState> { | |
if (this.state.contextMenuPosition) { | ||
contextMenu = <IconizedContextMenu | ||
{...contextMenuBelow(this.state.contextMenuPosition)} | ||
compact | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removing as the jump to date context menu shouldn't be Previously was not |
||
onFinished={this.onContextMenuCloseClick} | ||
> | ||
<IconizedContextMenuOptionList first> | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now styling a selector that we actually control from this component (
.mx_IconizedContextMenu_item
) instead of overriding.mx_AccessibleButton
which we use for all<MenuItem>
.This still allows us to nest buttons inside context menus without the need for
.mx_AccessibleButton:not(.mx_AccessibleButton_hasKind)
. For example the nestedGo
button in the context menu which should use the primary button styles and not the context menu item styles.