Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Fix newline on edit messages with quotes #7227

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions src/Markdown.ts
Original file line number Diff line number Diff line change
Expand Up @@ -56,12 +56,6 @@ function isAllowedHtmlTag(node: commonmark.Node): boolean {
function isMultiLine(node: commonmark.Node): boolean {
let par = node;
while (par.parent) {
// commonmark Parser separate quotes with blank quoted lines between them with
// paragraphs, so we need to consider it when the markdown is only a multiline quote.
if (par.type === 'block_quote') {
break;
}

par = par.parent;
}
return par.firstChild != par.lastChild;
Expand Down Expand Up @@ -135,7 +129,10 @@ export default class Markdown {
// 'inline', rather than unnecessarily wrapped in its own
// p tag. If, however, we have multiple nodes, each gets
// its own p tag to keep them as separate paragraphs.
if (isMultiLine(node)) {
// However, if it's a blockquote, adds a p tag anyway
// in order to avoid deviation to commonmark and unexpected
// results when parsing the formatted HTML.
if (node.parent.type === 'block_quote'|| isMultiLine(node)) {
realParagraph.call(this, node, entering);
}
};
Expand Down