Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Fix scroll Panel rendering for threads #7105

Closed
wants to merge 2 commits into from

Conversation

toger5
Copy link
Contributor

@toger5 toger5 commented Nov 10, 2021

When using rounded corners the current mx_AutoHideScrollbar css class causes issues.
If we use the browser specific scrollbar hiding flags, we can make it look better. If there are reasons not to use those, this can be closed.

Before:
Screenshot from 2021-11-10 12-44-01
After:
Screenshot from 2021-11-10 12-41-32


Here's what your changelog entry will look like:

🐛 Bug Fixes

  • Fix scroll Panel rendering for threads (#7105). Contributed by @toger5.

Preview: https://618bb4b2cdbaed0bb8c8ea81--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

@toger5 toger5 added the T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems label Nov 10, 2021
@toger5 toger5 requested a review from a team as a code owner November 10, 2021 11:51
@germain-gg
Copy link
Contributor

Thank you for filing this, I've already worked on this as part of #7100 should be ready for review this afternoon.

That will fix element-hq/element-web#19629

@toger5
Copy link
Contributor Author

toger5 commented Nov 10, 2021

Oh Fantastic!
Than I will close. Looking and learning from the threads code to get the timeline right panel card done.

@toger5 toger5 closed this Nov 10, 2021
@toger5 toger5 deleted the toger5/AutoHideScrollbar_rendering branch November 16, 2021 16:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants