Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Convert MessagePanel, TimelinePanel, ScrollPanel, and more to Typescript #6243

Merged
merged 7 commits into from
Jun 29, 2021

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Jun 22, 2021

Base automatically changed from t3chguy/ts/7 to develop June 22, 2021 21:34
@t3chguy t3chguy marked this pull request as ready for review June 24, 2021 15:41
@t3chguy t3chguy requested a review from a team June 24, 2021 15:51
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the diff overall is massive, so I probably missed something, but this looks good to go. Would recommend landing nowish to make the most of the pre-RC era.

src/@types/global.d.ts Show resolved Hide resolved
src/components/structures/MessagePanel.tsx Show resolved Hide resolved
src/components/structures/MessagePanel.tsx Show resolved Hide resolved
src/components/views/elements/EventTilePreview.tsx Outdated Show resolved Hide resolved
@jryans
Copy link
Collaborator

jryans commented Jun 28, 2021

Perhaps obvious, but this should definitely wait until after the RC branches tomorrow.

@jryans
Copy link
Collaborator

jryans commented Jun 28, 2021

Very impressive work all around, quite excited to have these core bits in TS! 😄

… t3chguy/ts/8

� Conflicts:
�	src/components/structures/MessagePanel.tsx
�	src/components/structures/TimelinePanel.tsx
… t3chguy/ts/8

� Conflicts:
�	src/components/structures/MessagePanel.tsx
�	src/components/structures/ScrollPanel.tsx
�	src/components/structures/TimelinePanel.tsx
�	src/components/views/elements/ErrorBoundary.tsx
�	src/components/views/elements/EventListSummary.tsx
�	src/components/views/messages/TileErrorBoundary.tsx
@t3chguy t3chguy merged commit 3fa89f3 into develop Jun 29, 2021
@t3chguy t3chguy deleted the t3chguy/ts/8 branch June 29, 2021 21:27
@turt2live turt2live restored the t3chguy/ts/8 branch June 29, 2021 23:35
@turt2live turt2live deleted the t3chguy/ts/8 branch June 29, 2021 23:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants