Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

[WIP] Rewrite MFileBody #6223

Conversation

SimonBrandner
Copy link
Contributor

@SimonBrandner SimonBrandner commented Jun 20, 2021

Fixes element-hq/element-web#16668

Screenshot_20210620_143010

This is a very rushed attempt to fix the above-mentioned issue.

  • Fix behaviour in file panel
  • Check if everything works as expected

@SimonBrandner SimonBrandner force-pushed the feature/download-button/16668 branch 2 times, most recently from 06dbfd8 to 3045ab7 Compare June 20, 2021 13:15
@robintown
Copy link
Member

How is this supposed to work for encrypted files, given that those currently require two clicks on the hyperlink to decrypt and then download? I just tried downloading an encrypted file, and it looks like it downloaded in an encrypted form.

@SimonBrandner
Copy link
Contributor Author

How is this supposed to work for encrypted files, given that those currently require two clicks on the hyperlink to decrypt and then download? I just tried downloading an encrypted file, and it looks like it downloaded in an encrypted form.

It should decrypt the file and then download it but as I say in the PR description, this is very rushed, so it doesn't work :P

@robintown
Copy link
Member

robintown commented Jun 20, 2021

Makes sense, though not sure if you're aware but you might run into some problems with that approach: element-hq/element-web#16087 (comment)

@SimonBrandner SimonBrandner force-pushed the feature/download-button/16668 branch 2 times, most recently from 7fc3f7f to a6eb025 Compare June 20, 2021 14:30
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
@turt2live
Copy link
Member

Just FYI that I'll be in this same area this week to move and fix the download button, which includes potential architecture changes.

@SimonBrandner
Copy link
Contributor Author

Closing in favour of #6386

@SimonBrandner SimonBrandner deleted the feature/download-button/16668 branch July 18, 2021 15:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The new uploaded file tiles should be clickable/have a download button
3 participants