Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Add message bubbles #6174

Closed
wants to merge 26 commits into from
Closed

Add message bubbles #6174

wants to merge 26 commits into from

Conversation

su-ex
Copy link
Contributor

@su-ex su-ex commented Jun 11, 2021

Related to element-hq/element-web#4635

Screenshots

1
2
3
4
5
6
7
8
9

Signed-off-by: Quirin Götz [email protected]

Copy link
Contributor

@SimonBrandner SimonBrandner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't have the time to go through everything but generally, this looks awesome! Just some minor things and questions. Thank you! 🚀

The stuff with the prefixes is probably up to the team.

And feel free to scream, if my suggestions don't make sense 😅

Edit: Also, regarding the curly braces... we've settled on { foo, bar }, instead of {foo, bar} for objects but a rule for the react-sdk hasn't been setup yet

src/components/structures/RoomView.tsx Outdated Show resolved Hide resolved
src/components/structures/RoomView.tsx Outdated Show resolved Hide resolved
src/components/views/elements/EventListSummary.tsx Outdated Show resolved Hide resolved
src/components/views/messages/MAudioBody.js Outdated Show resolved Hide resolved
src/components/views/messages/MFileBody.js Outdated Show resolved Hide resolved
src/components/views/messages/TextualBody.js Outdated Show resolved Hide resolved
src/components/views/messages/TextualBody.js Outdated Show resolved Hide resolved
src/components/views/messages/TextualBody.js Outdated Show resolved Hide resolved
src/components/views/messages/MessageEvent.js Outdated Show resolved Hide resolved
res/css/views/rooms/_BubbleLayout.scss Outdated Show resolved Hide resolved
Copy link
Contributor

@SimonBrandner SimonBrandner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would probably be for the second part of the review. I haven't made myself review the EventTile.tsx and _BubbleLayout.scss changes yet, but I think we should probably first decide on the things like the prefixes

Comment on lines +43 to +44
singleSideBubbles: false,
adaptiveSideBubbles: false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am probably totally overlooking where this is used

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once a build failed if singleSideBubbles wasn't there. Recently I noticed that adaptiveSideBubbles was missing and added it just in case. But I have absolutely no clue why this is needed either.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Odd

Revert "Add some strings that sprinkled away"

This reverts commit 4a12d62.
Copy link
Contributor

@SimonBrandner SimonBrandner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise. I have to admit that I've mostly skimmed through the CSS and the EventTile code. I am starting to understand why reviews can take a while sometimes 😅

src/components/structures/RoomView.tsx Outdated Show resolved Hide resolved
src/components/views/rooms/EventTile.tsx Outdated Show resolved Hide resolved
src/components/views/rooms/EventTile.tsx Outdated Show resolved Hide resolved
src/components/views/rooms/EventTile.tsx Outdated Show resolved Hide resolved
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
@t3chguy t3chguy requested review from a team June 14, 2021 21:27
@turt2live
Copy link
Member

hey @su-ex can we get some screenshots in the PR description to make review easier? Thanks!

@turt2live
Copy link
Member

@SimonBrandner now that your name is on the commits as well, we'll need signoff from you on here as well please.

@SimonBrandner
Copy link
Contributor

@SimonBrandner now that your name is on the commits as well, we'll need signoff from you on here as well please.

Ah, true:

Signed-off-by: Šimon Brandner <[email protected]>

@su-ex
Copy link
Contributor Author

su-ex commented Jun 15, 2021

@turt2live Sure, added! 📷

@nadonomy
Copy link
Contributor

@su-ex thanks for cherry picking your commits & iterating on your implementation into this PR after the discussion we had on Matrix, really appreciated!

The PR principally looks good, but we need to do a bit of internal planning (with @gsouquet @amshakal & @jryans) on precisely how we'll iterate on this so will figure out some details with them before we approve/merge.

Relatedly, we wouldn't consider element-hq/element-web#4635 closed until we're closer to shipping this on production, including de-risking some cross-platform efforts, so I've edited your PR description to avoid this.

Thanks again for the effort!

@jryans jryans changed the title Message bubbles for Element! Add message bubbles Jun 15, 2021
@jryans jryans requested review from germain-gg and removed request for a team June 17, 2021 09:09
@turt2live
Copy link
Member

Thank you for the work on this, and sparking the idea of how it could work - we really appreciate it. We've picked up the idea over at #6291 and hope to land it soon from the looks of it.

In the meantime, closing this in favour of #6291 - thanks again for taking a stab at this.

@turt2live turt2live closed this Jul 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants