Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Add a note to use the desktop builds when seshat isn't available #5225

Merged
merged 4 commits into from
Sep 22, 2020
Merged

Add a note to use the desktop builds when seshat isn't available #5225

merged 4 commits into from
Sep 22, 2020

Conversation

turt2live
Copy link
Member

Fixes element-hq/element-web#15184

This is currently temporary design for element-hq/element-web#12896 but does not fix it.

Documentation is left for element-hq/element-web#15190 to figure out

image
image
image
image

@turt2live turt2live requested a review from a team September 16, 2020 23:28
@t3chguy
Copy link
Member

t3chguy commented Sep 17, 2020

How does it look with some results, the ones from before it became encrypted

t3chguy
t3chguy approved these changes Sep 17, 2020
View reviewed changes
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

@turt2live
Copy link
Member Author

How does it look with some results, the ones from before it became encrypted

exactly the same, which is the intention.

@turt2live turt2live added the X-Release-Blocker This affects the current release cycle and must be solved for a release to happen label Sep 18, 2020
@turt2live
Copy link
Member Author

just double checking this is safe to land as-is with design

@ara4n
Copy link
Member

ara4n commented Sep 18, 2020

This copy implies that web can’t view encrypted files at all, which is untrue.

I’d suggest “...use the desktop app to view the encrypted file list” and “does not support viewing the encrypted file list”.

@nadonomy
Copy link
Contributor

This copy implies that web can’t view encrypted files at all, which is untrue.

Good point.

I’d suggest “...use the desktop app to view the encrypted file list” and “does not support viewing the encrypted file list”.

Just to exercise more brevity what about "Use the desktop app to see all encrypted files"?

@turt2live
Copy link
Member Author

@nadonomy that works for me :D

@turt2live turt2live mentioned this pull request Sep 18, 2020
Merged
@turt2live
Copy link
Member Author

@nadonomy I've also changed the copy for when there's no desktop builds to be "... viewing some encrypted files".

@turt2live turt2live merged commit 09dd3ce into develop Sep 22, 2020
@turt2live turt2live deleted the travis/ft-sep1620/09-enc-files branch September 22, 2020 16:25
@nadonomy nadonomy mentioned this pull request Sep 25, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nadonomy nadonomy nadonomy approved these changes

@t3chguy t3chguy t3chguy approved these changes

Assignees
No one assigned
Labels
X-Release-Blocker This affects the current release cycle and must be solved for a release to happen
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Seshat disablement in web/clarified documentation flags
4 participants
@turt2live @t3chguy @ara4n @nadonomy