Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Add support for blurhash (MSC2448) #5099

Merged
merged 18 commits into from
Jul 1, 2021
Merged

Add support for blurhash (MSC2448) #5099

merged 18 commits into from
Jul 1, 2021

Conversation

turt2live
Copy link
Member

MSC: matrix-org/matrix-spec-proposals#2448

While the image loads, we can show a blurred version of it (calculated at upload time) so we don't have a blank space in the timeline.

Example:
image

Done with a community hat on:

Signed-off-by: Travis Ralston <[email protected]>

MSC: matrix-org/matrix-spec-proposals#2448

While the image loads, we can show a blurred version of it (calculated at upload time) so we don't have a blank space in the timeline.
@turt2live turt2live added the Z-Community-PR Issue is solved by a community member's PR label Aug 11, 2020
@turt2live
Copy link
Member Author

self-selecting this as a community PR as it's p2 relative to other work.

src/ContentMessages.tsx Outdated Show resolved Hide resolved
@turt2live turt2live requested a review from a team August 11, 2020 04:10
@t3chguy t3chguy requested a review from a team August 11, 2020 08:42
@jryans
Copy link
Collaborator

jryans commented Aug 19, 2020

@turt2live Has Product been alerted to this idea? If not, I think we either need a review from them, or it needs to be behind a labs flag.

@turt2live
Copy link
Member Author

@jryans it definitely doesn't need a labs flag imo, but product and design will need to provide input at some point. Currently this is relatively low priority as it's an MSC implementation and not finalized yet, so it's already serving its intended purpose.

I'll take this out of the review queue as it's somewhat failed to get review, and I don't expect/anticipate it to land anytime soon anyways.

@turt2live turt2live removed the request for review from a team August 19, 2020 15:47
@t3chguy t3chguy self-assigned this May 18, 2021
… travis/blurhash

� Conflicts:
�	package.json
�	src/components/views/messages/MImageBody.js
�	yarn.lock
@t3chguy
Copy link
Member

t3chguy commented May 20, 2021

So this PR has only a subset of the support for MSC2448

  • Showing blurhashes on incoming timeline images
  • Sending blurhashes as part of thumbnail generation for images & videos

Not yet done:

  • Blurhashed stickers
  • Blurhashed room avatars
  • Blurhashed member avatars
  • Blurhashed URL previews
  • Blurhashed inline images

@t3chguy t3chguy removed their assignment May 20, 2021
@turt2live
Copy link
Member Author

In all honesty, those missing areas were deliberately out of scope for this PR

@t3chguy
Copy link
Member

t3chguy commented May 20, 2021

I was just summarising the current state.
I think the only one that I'll need to do for first cut will be local blurhashing for e2ee

@t3chguy
Copy link
Member

t3chguy commented May 21, 2021

Screen.Recording.2021-05-21.at.21.22.11.mov

image
image

This PR also fixes video thumbnailing in general, turns out it was totally broken at least in chrome, always yielding fully black frames.

@t3chguy t3chguy requested review from a team May 21, 2021 20:46
… travis/blurhash

� Conflicts:
�	package.json
�	src/ContentMessages.tsx
�	yarn.lock
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks great to me! There's some amount of updating to do to resolve conflicts, but otherwise it looks good. 😄

… travis/blurhash

� Conflicts:
�	src/ContentMessages.tsx
�	src/components/structures/UploadBar.tsx
�	src/components/views/messages/MImageBody.js
�	src/components/views/messages/MStickerBody.js
�	src/components/views/messages/MVideoBody.tsx
@t3chguy t3chguy merged commit a9e28db into develop Jul 1, 2021
@t3chguy t3chguy deleted the travis/blurhash branch July 1, 2021 20:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants