Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Initial support for verification in right panel #3796

Merged
merged 27 commits into from
Jan 20, 2020

Conversation

bwindels
Copy link
Contributor

@bwindels bwindels commented Jan 3, 2020

Requires matrix-org/matrix-js-sdk#1140
Part of element-hq/element-web#11224

verification-right-panel

Two big things happen in this PR (and the js-sdk PR):

  • merge responsibilities (track state of request, drive UI) of KeyVerificationStateObserver into VerificationRequest (in the js-sdk), and attach that object to all the involved events as event.verificationRequest. Synchronizing the toast, event tiles and right panel is a lot easier this way. VerificationToast, MKeyVerificationRequest and MKeyVerificationConclusion needed to be ported to this.
  • initial implementation of the verification right panel

I have tested that to_device verification still works, especially for verifying your own devices, as we might still need this for cross-signing.

Apologies that the commit log is a bit messy, might be better to review the changes in their entirety.

Cleanups still to do:

  • fix lint errors
  • remove debug logging
  • move label functions in KeyVerificationStateObserver.js to a place that makes more sense now the class is removed there

@bwindels bwindels marked this pull request as ready for review January 4, 2020 12:01
@bwindels bwindels requested a review from a team January 4, 2020 12:01
@turt2live turt2live requested review from turt2live and removed request for a team January 16, 2020 19:42
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like the js-sdk, this is hard to follow but I think it's fine. It's slightly easier to follow than the js-sdk though, so there's that.

src/components/views/messages/MKeyVerificationRequest.js Outdated Show resolved Hide resolved
src/components/views/toasts/VerificationRequestToast.js Outdated Show resolved Hide resolved
src/stores/RightPanelStorePhases.js Show resolved Hide resolved
@turt2live
Copy link
Member

I've also merged in develop here having broken the build system

@turt2live turt2live mentioned this pull request Jan 18, 2020
@bwindels bwindels merged commit 95a0eba into develop Jan 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants