-
-
Notifications
You must be signed in to change notification settings - Fork 833
Rewire the Sticker button to be an Emoji Picker #3747
Conversation
Any Updates here? 😄 Would be greate to have this merged! |
Blocked on designer who is busy doing FOSDEM graphics and Cross Signing stuff :( we have to be patient |
Any updates here? The current emoji solution is a real mess and I'd also like to see that PR merged sooner than later. I quite often write messages in my iPhone instead in my opened Riot-Web just because I know I need some emojis ... |
Soon its March 2020.... any update from the Fosdem Designer? @lampholder please priotize such important UI stuff 😞 |
FYI all we've kicked off the design process on a new more extensible and scalable composer design for web, iOS & Android. We've opted for this as it means we can get things right in the long term. Once we make good headway there, we'll run the design proposals through the major stakeholders per platform to figure out an execution plan, which will include very low hanging near-term tweaks (like this one!) that are aligned with long term direction. |
@nadonomy do you have an rough estimation? Another 6 Months? 😞 |
Snark aside— unfortunately the designer working on this has been ill for the last 2 weeks (since the day after they started on the designs). Totally undesirable delay, but the designs will be ready when they're ready. |
…b.com:matrix-org/matrix-react-sdk into t3chguy/emoji_picker_composer � Conflicts: � src/components/views/rooms/MessageComposer.js
Signed-off-by: Michael Telatynski <[email protected]>
Latest ^ Build at http://riots.im/adhoc/emoji1/ |
Looks pretty good! Any chance element-hq/element-web#6998 could get fixed here as well? The composer is starting to get lots of buttons. |
Also in the tooltip "Show Stickers" has "stickers" capitalized but all of the other buttons there only have the first word capitalized |
Would love to, but that would mean waiting on product decision which would mean it'd miss next release so no.
Fair but not a regression so don't want to fix it |
Signed-off-by: Michael Telatynski <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, looks good to me!
Signed-off-by: Michael Telatynski <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with the caveat that we should fix the context menus spawning differently as a part of polishing the composer in the near future.
…b.com:matrix-org/matrix-react-sdk into t3chguy/emoji_picker_composer
Ping @verysanghee - this is interesting for you |
Fixes element-hq/element-web#1107
Things left to do: