This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Accessibility fixes to the LeftPanel #3499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
dbkr
approved these changes
Oct 1, 2019
| if (ctrlCmdOnly) { | ||
| dis.dispatch({ | ||
| action: 'focus_room_filter', | ||
| }); | ||
| handled = true; | ||
| } | ||
| break; | ||
| case KeyCode.KEY_BACKTICK: | ||
| case Key.BACKTICK: | ||
| if (ev.key !== "`") break; |
There was a problem hiding this comment.
What's the story here? Different keyboard layouts? If so, how do those people use the shortcut?
There was a problem hiding this comment.
There was a problem hiding this comment.
The shortcut was broken for some people, not others: element-hq/element-web#10031
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#10031
Fixes element-hq/element-web#10845
Also makes screen readers a lot more useful for the Room List, Room Sub Lists and Room Tiles