This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Disable MSISDN registration if the homeserver doesn't support it #3368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jryans
approved these changes
Sep 2, 2019
There was a problem hiding this comment.
Thanks for decoding this somewhat complex issue!
I think this looks like the correct change to me as well. The other area to consider would be the Account section of Settings, but it looks like this was already hiding both email and MSISDN together if the server requires an IS and we don't have one.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#10599 (I think?)
I'm failing to understand the full scope of the issue, but similar checks to this are already all over password reset and settings - it was just registration that missed it for msisdn only.