This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Support homeserver-configured integration managers #3340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes element-hq/element-web#4913 Requires matrix-org/matrix-js-sdk#1024 Implements part of [MSC1957](matrix-org/matrix-spec-proposals#1957)
This was referenced Aug 23, 2019
bwindels
approved these changes
Aug 27, 2019
| try { | ||
| console.log("Updating homeserver-configured integration managers..."); | ||
| const homeserverDomain = MatrixClientPeg.getHomeserverName(); | ||
| const discoveryResponse = await AutoDiscovery.getRawClientConfig(homeserverDomain); |
There was a problem hiding this comment.
This will do it's own .well-known request, right?
Is there no way here to re-use the response of the .well-known response request to determine the homeserver?
There was a problem hiding this comment.
It does do a .well-known request, and the existing response from the homeserver isn't really able to be reused. The .well-known for the homeserver is done so early in the process that we don't have a clean/reliable way to get it all the way over here, and we need to update this information periodically.
|
(I am hoping that answers your question - if not, I can try and answer better and/or make additional PRs) |
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#4913
Requires matrix-org/matrix-js-sdk#1024
Implements part of MSC1957