This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Remove cancel button from final key backup screen #2418
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Canceling the dialog once the backup was created meant onFinished was called with false which RoomView interprets as the backup not being done. This does mean you can't just hit esc to clear the dialog once you're done: if we wanted this we could fix this in a better way. element-hq/element-web#8066
|
Actually, having looked at the other sticking points, I'm going to do this a different way. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Canceling the dialog once the backup was created meant onFinished
was called with false which RoomView interprets as the backup not
being done.
This does mean you can't just hit esc to clear the dialog once you're
done: if we wanted this we could fix this in a better way.
element-hq/element-web#8066